Use GIX_TEST_FIXTURE_HASH for gix-worktree-stream#2543
Draft
Christoph Rüßler (cruessler) wants to merge 6 commits intoGitoxideLabs:mainfrom
Draft
Use GIX_TEST_FIXTURE_HASH for gix-worktree-stream#2543Christoph Rüßler (cruessler) wants to merge 6 commits intoGitoxideLabs:mainfrom
GIX_TEST_FIXTURE_HASH for gix-worktree-stream#2543Christoph Rüßler (cruessler) wants to merge 6 commits intoGitoxideLabs:mainfrom
Conversation
This is breaking because `Stream::add_entry_from_path`'s API has changed. It now takes `hash_kind` as an argument.
`gix-worktree-stream` actually has `#[cfg(feature = "sha256")]` in two places.
Christoph Rüßler (cruessler)
force-pushed
the
run-gix-worktree-stream-tests-with-sha-256
branch
from
7605705 to
74a08aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed with the following error message:
This is odd as, in this PR,
gix-worktree-streamis only at version0.30.0.Open questions
byte_to_hashandhash_to_bytecorrect?TryFrom<&super::Store> for super::Store, do we want to replaceuse_multi_pack_index: falsebyuse_multi_pack_index: s.use_multi_pack_index?This is part of #281